Ondrej Medek

Results 108 comments of Ondrej Medek

You should use English only in the text and commit message, too.

Just a few headings are wrong in the README.md, byt this commit diff changed all content - probably wrong line endings?

It's not a problem by PR, but by your Git settings, check the git config `core.autocrlf`.

If you want to have secure application, then never keep your secrets in the memory due to the [heart bleed attacks](https://heartbleed.com/). Hence, the `OAuth2Session` should not keep the `client_secret` in...

@Lukasa thanks for the clarification. I didn't realize the problem with the Python memory management.

@ktalebian This question is more about OS details (Windows Credential Manager, MacOSX Vault, Linux libsecret). `keytar` is just a Node.js wrapper for OS functions. Generally, the protection is against data...

`keytar` require may fail for various reasons. As a workaround, do keytar require like this: ```js let keytar; try { keytar = require('keytar'); } catch (err) { console.err('keytar cannot be...

It would be better to have some pluggable architecture to plug any custom encode/decode, (compress/uncompress, obfuscate, ...) code. Then, some default encryption implementation may be provided, too.

@matanlurey @epoberezkin maybe #196 is better approach?