ajv-cli Skip registering additional schemas that match the main schema.

Skip registering additional schemas that match the main schema.

Open matanlurey opened this issue 4 years ago • 9 comments

Closes https://github.com/ajv-validator/ajv-cli/issues/172.

Let me know if you prefer this done another way, or would like different kinds/quantities of tests!

Oct 03 '21 22:10 matanlurey

It looks like TS change that was breaking ajv now breaks this one - will look into it later.

Thanks for the PR - it looks ok!

Oct 04 '21 06:10 epoberezkin

@epoberezkin Do you want me to fix the issues in this PR? They look small, and can probably unblock pretty fast.

Oct 04 '21 18:10 matanlurey

absolutely, please have a look.

Oct 05 '21 20:10 epoberezkin

@epoberezkin Thanks. npm run lint seems to pass locally, passing over to you for a workflow run :)

Oct 06 '21 04:10 matanlurey

Polite ping :) @epoberezkin

Oct 21 '21 18:10 matanlurey

It's now the same typescript change I fixed earlier in Ajv... I will look over the weekend

Oct 21 '21 20:10 epoberezkin

Sg, thanks!

Oct 21 '21 20:10 matanlurey

it's actually and error specific to this change - it does not happen in the master branch.

It is definitely because of the change in this PR - specifically, the change in logJSON type signature - why was it needed?

Could you please reduce the change to what is necessary, also you should be able to run the tests locally (I also enabled builds)

Oct 24 '21 18:10 epoberezkin

@matanlurey @epoberezkin maybe #196 is better approach?

Feb 04 '22 12:02 xmedeko