fix(llvm) Improve runenvs for llvm and clang toolchain
This PR enable the usage of sanitizers on windows without manual DLL copy or PATH setting with llvm and clang toolchains
Summary of Changes
Hello @Arthapz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses critical linking issues for LLVM-based projects on Windows, specifically concerning compiler-rt builtins and libc++ libraries. It introduces robust mechanisms for xmake to correctly locate and link these components, ensuring proper compilation and execution. A new dedicated test case has been added to validate these fixes.
Highlights
- New LLVM Compiler-RT Test: A new test project
llvm_compiler_rthas been added, includingmain.cwhich uses__int128to verifycompiler-rtbuiltins, andtest.luato automate its build and execution with the LLVM toolchain onxmake. - Enhanced LLVM Path Detection: New functions like
_get_llvm_resourcedirand_get_llvm_compiler_win_rtdir_and_linkwere introduced inxmake/modules/core/tools/clang.luato improve the detection of LLVM's resource, root, andcompiler-rtlibrary directories, particularly for Windows environments. - Explicit Windows LLVM Linker Fixes: The
nf_runtimefunction inxmake/modules/core/tools/clang.luanow explicitly manageslibc++include paths and forces the linking ofcompiler-rtbuiltins on Windows, addressing known issues with automatic linking in LLVM on this platform. - Expanded Compiler Runtime Tool Support: The
compiler_runtimerule inxmake/rules/utils/compiler_runtime/xmake.luahas been updated to recognizeclangas a valid compiler when determining and applying default Visual Studio runtimes on Windows.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
i don't have much time currently, i'll fix the pr when possible
please wait for this patch https://github.com/xmake-io/xmake/pull/7095
then use toolchain:memcache() to cache some stuffs