Xiliang Chen

Results 373 comments of Xiliang Chen

A quick update. I started the refactor work to improve xtokens based on the asset_transfer implementation. However, recently there are also few more issues and improvements have been raised about...

With all the additional complicated requirements, I am considering maybe we should just deprecate xtokens and use pallet-xcm instead. xtokens is built because there was no pallet offers such functionality....

I think it is best to keep xtokens as it is for compatibility reason and for new use cases, use new features from the pallet-xcm

this is a crash inside wasmi, the wasm interpreter, which is very strange. I guess it could be a bun bug as it is not happening on nodejs

I just don't like the approve/transferFrom model. I understand we need it for ERC20 but I don't want to expose them in pallets. There is no reason user should use...

We need a mode to handle block finalization strategy. Add new config finalize-block-mode that can be: - 'latest': (the default behaviour that always mark latest block to be finalized -...

I am not sure if we want a central config. In fact, a well written pallet should not be reading `System::block_number` and instead have its own config type to allow...

> But this will lead to all pallets having a BlockNumberProvider config item, which is why it could be de-duplicated by just putting into System. No. Only pallets depends on...

Yes. I don’t see much changes needed in frame system. We just need to migrate each pallet one by one and maybe add some helpers.