Xiliang Chen

Results 371 comments of Xiliang Chen

It is required to prevent dust account. You can't keep account without balance. This is the corresponding logic in Substrate https://github.com/paritytech/substrate/blob/a2fdd15c047289426e6023f393ee9172d81cc0ff/frame/system/src/lib.rs#L1609

And now you have dust account issue. But we do plan to refactor all the ref count code with the recent changes https://github.com/AcalaNetwork/Acala/issues/784

ok. I will revisit this issue after we finished the refactor

it is something to be used by all the runtime and potentially used by other parachains. Like https://github.com/paritytech/polkadot/blob/54d1cb9178fd41b535d8d908b021926d01d91f00/xcm/xcm-builder/src/location_conversion.rs#L104

Yeah we should allow `DepositAsset` the unused fees back. Also maybe should support `ReserveAssetDeposited` so it is possible to send some funds from relay chain for the tx fee. Otherwise...

The main issue is that it is not really a constant for Acala https://github.com/AcalaNetwork/Acala/blob/35078ea2b2d0e3a3937a075c54d94c77faea2f36/runtime/acala/src/lib.rs#L770-L793 Even if they are constant, I am not sure what's the best way to expose a...

Yep that will be a good solution.

You should be able to implement your own adapter. Moonbeam team is using xtokens with pallet-assets: https://github.com/PureStake/moonbeam/pull/680

Contributions are welcome. Just that it needs to be feature gated to avoid pulling pallet-assets to projects that not using it.

Without this it is impossible to iterate blocks so I would give this a bump on priority.