Xin Kai Lee

Add `ImmersedPressureSolver` with `FFTBasedPoissonSolver` as preconditioner for complex domains

2

Using the `FFTBasedPoissonSolver` in complex domains on the `ImmersedBoundaryGrid` leads to resulting solution that either 1. Does not conserve tracers in the flow; or 2. Leads to divergent flow along...

Fix index calculation for Lagrangian particles in periodic directions

10

Closes #3415

`LagrangianParticles` get moved at the right of `Periodic` topology when it shouldn't be

3

I noticed that in the `Periodic` directions, particles that have coordinates within the last cell at the end of the domain get moved into the first cell when I think...

`JLD2OutputWriter` and `Checkpointer` don't work when `max_filesize` and `part` are specified.

2

Below is a minimal working example of the problem: ```julia using Oceananigans using Printf grid = RectilinearGrid(Float64, size = (4, 4, 4), x = (0, 1), y = (0, 1),...

Modify `NonhydrostaticModel` to include different advection schemes for velocities and tracers

7

This PR would allow the user to choose the advection schemes they wish to use for velocities and tracers separately. This improves customizability as well as allowing the user to...

Allow different advection schemes for momentum and tracers in `NonHydrostaticModel`

1

Currently, `NonHydrostaticModel` does not support specifications for `momentum_advection` and `tracer_advection`. It would be nice to include a feature like this, as has been implemented in the `HydrostaticFreeSurfaceModel`. @simone-silvestri

`maximum(abs, v)` doesn't work on GPU in Julia 1.10.0 with grid size larger than (10, 10, 10)

14

(as discussed with @simone-silvestri) I encountered this bug when trying to upgrade to julia 1.10.0. What happens is `maximum(abs, v)` doesn't work for grids larger than (10, 10, 10). However...

Results are wonky when running `examples/three_layer_constant_fluxes.jl` with free convection

5

I ran `examples/three_layer_constant_fluxes.jl` with the command as follows: `unbuffer ~/julia-1.6.1/bin/julia --project examples/three_layer_constant_fluxes.jl --size 256 256 128 --extent 512 512 256 --hours 192 --buoyancy-flux -4e-8 --momentum-flux 0 --name free_convection_8days_2 --animation`, and...

When trying to instantiate `LESbrary.jl` on Supercloud, I receive the error message below: `ERROR: expected package NonlinearSolve [8913a72c] to be registered`