Xin Kai Lee

Results 13 comments of Xin Kai Lee

Here's a test script: ```julia using Oceananigans using Oceananigans.Units using StructArrays using Printf using Random using Statistics Random.seed!(123) grid = RectilinearGrid(CPU(), Float64, size = (2, 2, 2), halo = (5,...

This seems to be ready to merge? @glwagner @simone-silvestri @jagoosw

This resolves issue https://github.com/CliMA/Oceananigans.jl/issues/3415. See this script: ```julia using Oceananigans using StructArrays using Printf grid = RectilinearGrid(CPU(), Float64, size = (10, 10), halo = (5, 5), x = (0, 1),...

Is what I've done linking #3415 and #3416 correct?

> Even if curvilinear grids are not supported yet for the non-hydrostatic model, I like the idea of moving `validate_momentum_advection` to `Models` like `validate_tracer_advection`. does this mean that I should...

I can change all instances in `./examples`. Should I change everything else too? If not which ones should I change?

> This seems correct for Periodic topologies but wouldn't it be the case for Bounded too. Do particles get bounced if you put them just to the right of the...

> @xkykai do you think you could run some immersed boundary tests with this branch to make sure this change doesn’t affect your work? I think we’re interested in both...

> We could think about a `ParticleAdvectiveForcing` or also a `ParticleVelocityTendency` function that specifies the rhs of dvdt=G One example that this might be tricky for this approach is where...

> > > We could think about a `ParticleAdvectiveForcing` or also a `ParticleVelocityTendency` function that specifies the rhs of dvdt=G > > > > > > One example that this...