Justin Krinke

Results 8 comments of Justin Krinke

@KhealthDavid can you please add some tests. Thanks

Great idea, just follow the pep guide lines https://www.python.org/dev/peps/pep-0561/ which I think mypy supports.

Thanks @davidhessler for the interest, you are more than welcome to contribute to the project. Please ensure when creating a pull request to include appropriate unit tests.

Thanks for the input @uriyay, I left some comments on your PR.

@pizzapanther thanks for the contribution to the project, could you please add a unit tests for the proposed changes?

@jenskdsgn thanks for the contribution could you by chance write some unit tests for ` ws_subprotocol`?

@uriyay thanks for the contribution, however this change as you can see breaks tests on the existing functionality. We should potentially introduce checking if session is the instance of Session....

Thanks for the contribution @Tom1204, could you add some tests to ensure passing kwargs and options works as expected.