Xinya Zhang

Results 19 comments of Xinya Zhang

> So adding this should be relatively easy. Unfortunately `sf_get_string` is not the end of the story. `sf_get_string` actually does not read the `id3` chunk in `.wav` files. Instead its...

> If you're aiming to make it read only, and without album art support -- it's as simple as adding a new API, with a minor change to avoid rewind....

@Alexey-Yakovenko I tried [some changes](https://github.com/xinyazhang/deadbeef/commit/b50f0626f72f07e3784934c0badcb98b68c5775f) to let sndfile plugin read id3 tags without changing the API, but there are still some problems left. 1. chunk related functions were introduced in...

> Thanks for this fix. A few requests: > > * Please describe the problem this fixes. What happens if reference_p is uninitialized? > > * The problem exists in...

I found the result depends on what BV you're using. The only working choice as far as I know is RSS. None of AABB/OBBRSS/kIOS work for me. OBB and kDOP...

Hi @Seemee There is an error message in the screenshot "Can't find address of local shedd" I think the reason is the HTcondor was not properly started in the container....

> can u pls resolve conflicts first? thx Updated @ytaous

> pls fix lint error A few remaining lint problems: 1. `s = s.replace(...)` in python, which is common practice. 2. `long long int` usage in `onnxruntime/core/providers/rocm/shared_inc/fpgeneric.h`, which is the...

I think the C++ lint error is a false alert. Those lines do not exceed the 120-character limit The Python is the conventional `s = s.replace(...)` practice.

> Hi any update on this? No hurry, we can try to close the others before this one, thx. Working on PR #11968 and #11972 now. Will go back to...