Xin Zhang

> @xin-zhang2 : Thanks for this change. > > Its a bit odd that the join order changed in q58, especially since neither column pruning or window pushdown seems to...

@hantangwangd Thanks for the review. I tried adding a new test case in `TestLogicalPlanner` for this changes, but found it somewhat tricky to construct a SQL query that meets the...

@hantangwangd Yes, that's exactly the point. The `WindowNode` with two functions `row_number` and `count` was constructed by a new rule in TVF implementation instead of `GatherAndMergeWindows`. When I tried with...

@hantangwangd The WindowNode in the TVF code is constructed in [line 351 of ImplementTableFunctionSource](https://github.com/prestodb/presto/pull/25032/files#diff-b32cac3ca5fff1ccde184d5532e4f3036cefd070815e140ca2e13e48be7aad29R351) ``` PlanNode window = new WindowNode( source.getSourceLocation(), context.getIdAllocator().getNextId(), source, specification, ImmutableMap.of( rowNumber, new WindowNode.Function(rowNumberFunction, FULL_FRAME, false),...

@hantangwangd Thanks for the suggestion! Yes, I updated the TVF rule to consturct two WindowNodes, and the existing optimization now works as expected, as long as the the TVF Node...

@jaystarshot Thanks for the review. An end to end integration tests requires the changes in `LocalExecutionPlanner` and `TestingTableFunctions` which defines all the table functions used for testing. These change are...

@tdcmeehan Hi Tim, would you mind helping review this PR while Jay is ooo, if possible? Thanks in advance!

Did a rebase to resolve the conflicts. @jaystarshot Would mind continue reviewing this PR? Thanks!