Xigang Wang

fixed: https://github.com/kubernetes/kubernetes/pull/132400 /close

/cc @mbobrovskyi PTAL.

> Also maybe here: > > https://github.com/kubernetes-sigs/kueue/blob/89f1c037aab465d5d8faf3b0668e5c7cf10c8b46/pkg/controller/admissionchecks/multikueue/admissioncheck.go#L128 > > https://github.com/kubernetes-sigs/kueue/blob/89f1c037aab465d5d8faf3b0668e5c7cf10c8b46/pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler.go#L61 > > https://github.com/kubernetes-sigs/kueue/blob/89f1c037aab465d5d8faf3b0668e5c7cf10c8b46/pkg/controller/admissionchecks/multikueue/admissioncheck.go#L124 > > https://github.com/kubernetes-sigs/kueue/blob/89f1c037aab465d5d8faf3b0668e5c7cf10c8b46/pkg/controller/admissionchecks/multikueue/multikueuecluster.go#L425 Done.

> What if the cache still has non-existent objects? Did you check if there is no any path to have outdated cache information? Here, we check whether the object exists...

@mbobrovskyi PTAL. Thanks!

@tenzen-y The Kueue cache can indeed run into stale data issues. What I’m thinking is to ensure eventual consistency by handling Delete events in the Informer’s EventHandler. Alternatively, we could...

@mbobrovskyi Fixed, please take another look.😄

> But it should be placed outside the function, not inside. WDYT? @mbobrovskyi I personally feel we might not want to expose `IgnoreNotFound` externally. It might be cleaner and more...

@tenzen-y That's right — if the reconcile fails, the key will be requeued into the workqueue.

> Could you please also close resolved comments? It is very hard to understand which one is Done. All resolved comments have been closed.