Xigang Wang

Results 14 comments of Xigang Wang

cc @hongchaodeng @hexfusion @hasbro17 please review, thx:)

@hexfusion Why is etcd-operator designed to not allow modification of etcdEnv? https://github.com/coreos/etcd-operator/blob/master/pkg/apis/etcd/v1beta2/cluster.go#L134

> @hexfusion Why is etcd-operator designed to not allow modification of etcdEnv? > https://github.com/coreos/etcd-operator/blob/master/pkg/apis/etcd/v1beta2/cluster.go#L134 I know the reason, container env is not allowed in patch. ![image](https://user-images.githubusercontent.com/3377677/72577474-e191ac80-390d-11ea-9cf1-059af9f26fdd.png)

> Hi @xigang , I have changed to structed objects in cache, and you can request in pb type. Set it in your client's restconfig: > > ```go > restConfig.AcceptContentTypes...

@ikaven1024 In a federated cluster with 5.6W nodes, List 91W pods request test results: Pod Total | Transfer Protocol | RT -- | -- | -- 91W | application/json |...

@ikaven1024 If protocol buffer are used, CRD is not supported. there will be this flaw.

> > ```go > > restConfig.AcceptContentTypes = "application/vnd.kubernetes.protobuf,application/json" > > ``` > > If you set AcceptContentTypes as `application/vnd.kubernetes.protobuf,application/json`, response type should be adaptive, pb for intree objects, and json...

@ikaven1024 I used CRD typed client for testing. the client requests headers: ``` I0105 11:53:39.844297 1315213 round_trippers.go:182] Request Headers: I0105 11:53:39.844308 1315213 round_trippers.go:186] Accept: application/vnd.kubernetes.protobuf,application/json I0105 11:53:39.844316 1315213 round_trippers.go:186] User-Agent:...

> > ```go > > restConfig.AcceptContentTypes = "application/vnd.kubernetes.protobuf,application/json" > > ``` > > If you set AcceptContentTypes as `application/vnd.kubernetes.protobuf,application/json`, response type should be adaptive, pb for intree objects, and json...