Max Schaefer

Useless field assignment in `query_handler.go`

1

**Describe the bug** It looks like [this assignment](https://github.com/uber/aresdb/blob/5038e4c7fc27c7eab8c01195504fd6496bcf083c/api/query_handler.go#L251) to `aqlRequest.Verbose` is dead (the field is never read in the same function, and `aqlRequest` is not a pointer). **To Reproduce** I...

**Describe the bug** It looks like [this assignment](https://github.com/uber/aresdb/blob/5038e4c7fc27c7eab8c01195504fd6496bcf083c/query/aql_nonaggr_batchexecutor.go#L96) to `bc.size` is dead (`bc` is a local variable which does not escape, and the field is not read anywhere). **To Reproduce**...

Consider an HTML page including two scripts `1.js` and `2.js`, where `1.js` is ``` javascript var x; ``` and `2.js` is ``` javascript alert(x); ``` Loading this page alerts `undefined`....

Duplicate switch case

2

[This case](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L3829) is already covered [here](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L3818).

Here: https://github.com/asgerf/tscheck/blob/master/tscore.js#L1030

[These](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L2610) [three](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L2801) [calls](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L2802) to `visitExpVoid` either should be calls to `visitExp` or should not have a second argument (which `visitExpVoid` ignores).

[This](https://github.com/asgerf/tscheck/blob/master/tscheck.js#L667) should probably be `return x;` instead of just `x` (currently it falls through and accidentally DTRT).

Looking through the packages with command-line injection vulnerabilities, I noticed that two of them have been unpublished (`corenlp-js-interface` and `corenlp-js-prefab`). With npm that is, of course, always a possibility, since...