xiaoyinl

Results 25 comments of xiaoyinl

I opened a PR on Jython repo, which will hopefully fix this bug.

@ryanmkurtz FYI, according to a [comment](https://github.com/jython/jython/issues/159#issuecomment-1179675592) by @jeff5, 2.7.3 final will be released in about 6 weeks.

@ericlaw1979 Could you please review?

@ericlaw1979 I think just showing "Status: xxx is currently preloaded" is fine. The code mistakenly treats the error of _removal_ as error of _preloading_. "But has the following issues" and...

> The domain is at risk of removal (ignoring #106 in the case of wikipedia.org) – the front page of hstspreload.org clearly states this: Actually it's not at risk of...

@emteere > How does the parse look otherwise if you move the const before the LONG64, which the parser does accept? Hoping most of the issues have been sqaushed with...

> How does the parse look otherwise if you move the const before the LONG64, which the parser does accept? Hoping most of the issues have been sqaushed with the...

I wonder if it's better to mention that Windows SDK and ATL are required in README.md? ATL is an optional component, and it's not installed by default if users only...

@ryanmkurtz I agree with all your comments. But I don't have time recently to make these changes. Could you make these changes yourself?

> The URL you provide is for Microsoft/Visual Studio C++ Build Tools, but then there is also Visual Studio Build Tools which uses a different installer GUI (similar to the...