CQ Xiao comments

Results 93 comments of


                                            CQ Xiao

rumqttc - ack with reason code

Proposed some solution with `ack` packet, please check: https://github.com/bytebeamio/rumqtt/pull/855

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

> Made some changes to the design, but basically the same concept, please review the POC presented in the following commit(with example), comments on this are welcome! > > [b6a45b7](https://github.com/bytebeamio/rumqtt/commit/b6a45b7713eebf8207abbff5a7588317fd27f7ab)...

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

I did some changes based on your POC and did some validation locally, I share the changes in PR here: https://github.com/bytebeamio/rumqtt/pull/851, feel free to use them to in improvement feature...

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

Given the successful POC and code reviews, I believe the ACK await feature is great. What are the next steps to ensure a smooth integration?

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

According to the recent changes in https://github.com/bytebeamio/rumqtt/pull/869, the notice struct needs update. `FixedBitSet` helps to reduce memory usage comparing to vec, but is not suitable for the ack waiting, since...

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

Another thing, while waiting ACKs, it's possible the connection is reconnected with broker CONNACK session present=0, in such case, the pending waitings should be terminated with some error (state error...

Keep the ACK ordering when using manual ACK

Is there any comments about this issue?

publish / subscribe / unsubscribe methods return a notice future that waits publish (QoS0), PubAck (QoS1) and PubRec (QoS2)

Some updates for reference: * Sync with latest `acked` * HashMap -> VecDeque * To save memory * VecDeque is fast to push_back and pop_first * Publish NoticeTx * Notify...

WCID support

Currently USBX accepts ascii string and extend it to unicode string (padding zero on each ascii byte) defined by USB spec. The WCID have a vendor ID and a padding...

Is there a USBX HOST PIMA reference code ?

Define `UX_PIMA_WITH_MTP_SUPPORT` and compile again to enable MTP support. PIMA manages files as objects, you can use object functions to access your files. Usually you should open a session, get...