xiaobao66

Results 8 comments of xiaobao66

Same issue. In the `_autoResume` function, AudioContext is only resumed when Howler state is 'suspended' or Howler state is 'running' and ctx.state is 'interrupted'. https://github.com/goldfire/howler.js/blob/f128f9d975c2bc87610eac0eab5239980b3a4dda/src/howler.core.js#L524 It loses the case: Howler...

@STRML Sorry, I don't know how to write a regression test for this fix. Do you mean add a example in the test directory?

> Yes, something in `test/spec` that fails under the old code but succeeds under the new. Sorry, I don't know what fails under the old code. I didn't change `test/spec`...

@STRML I find `test/spec` only test function, but GridItem.jsx is a react component. This is my first time to commit pr, so I don't know how to add a test...

Ok, I will look at it first and then spend time adding the test

@STRML I have added a test case for the fix.But it shows `Run actions/labeler@v2 failed`, > ##[error]HttpError: Resource not accessible by integration > ##[error]Resource not accessible by integration > ##[error]Node...

> ![image](https://user-images.githubusercontent.com/51307874/92671512-0decb400-f349-11ea-99a4-bf2f3fadd261.png) > 我也是antdV3升级V4遇到这个问题,删掉这行代码就可以运行了,请问有其他解决办法吗?还有这个不是写了 /* stylelint-disable-next-line function-calc-no-invalid */,为什么还会有问题呢 查看下你的less版本,不要使用最新的^3.12,我使用3.10.3没有报错