Xiangce Liu comments

Results 81 comments of


                                            Xiangce Liu

[Draft] feat: Handle malware sources with many matches

Hi @mhuth - I'm closing this PR as it's very behind the master branch, and long time not updated in "Draft" status. Please rebase and reopen it if it's necessary.

New parser for nftables

Hey @matysek - Thanks for your detailed explanation. Based on the investigation of yours and @vishwanathjadhav 's, I think a new parser for `nft` and a combiner (just like the...

Rework toposort algorithm as an ancestor traversal

@PaulWay - The same as #3604, this PR changes a very basic level method, it also needs to be tested and compared to check the performance improvement. However, in another...

implement tower venv rule

Closing it, please open it in another new PR when necessary.

feat: new datasources: host_key_files

@shlao as mentioned, we need to reconsider if it's worth adding this spec to core collection, do you have a Jira card to get this spec being approved first?

fix: no valid conf found issue for uefi rhel9 in combiner GrubConf

@JoySnow this PR is ready for merging, please file a new PR to `3.0_egg` branch per the steps given in [RPM/Egg Delivery](https://github.com/RedHatInsights/insights-core/blob/master/CONTRIBUTING.md#rpmegg-delivery)

fix: add missing doc for several parser files

Closing it for now, Please open it in another new PR if necessary

Refactor client networking and auth code

Closing it for now, we can re-open it in another new PR when necessary.

chore: Improve and simplify logging

Hi @m-horky - Sorry for bringing this trouble to you, as we just resolved an urgent bug within the repo. Please rebase the master branch of your fork of insights-core...