Tobias Bengfort

Frontend unit tests failing when used with blanket

1

If I run the frontend unit tests in the browser, many tests fail. If I run the exact same tests in exactly the same setup, but without blanket, everything works...

## The current situation The information from the meta API is available via two entirly different systems in the frontend: The `adhMetaApi` service and some TypeScript code that is generated...

incomplete detection of references on deepPost (batch API)

4

The batch API allows to send a sequence of virtual requests in a single physical request. `deepPost` is an abstraction in the frontend that allows to post an arbitrarily ordered...

Websocket ignores errors

1

The current websocket implementation logs error messages, but does not interpret them in any way. This means that failing subscriptions are not detected. As websockets are mostly used for caching,...

Comments are hard to find

1

See #2618 The issue: > User testing for S1 has shown that people miss the fact that they can show the comments column because they think that this is just...

Proper use of <a> and <button>

1

We almost never use a `` element and often have `` elements without a proper `href` attribute. This should be fixed: - Links (used for navigation) should use the ``...

Fonts not available in styleguide

2

The fonts as defined in `_fonts.scss` are not available in the styleguide and therefore not loaded.

Angular 2 has finally been [released on 15.9.2016](https://angularjs.blogspot.de/2016/09/angular2-final.html). I could not find any information on the deprecation strategy for angular 1, but it will definitely be deprecated eventually. So we...

> For security concerns we should also make the admin user a normal user with the admin role instead of bypassing any security check. > > -- https://github.com/liqd/adhocracy3/issues/2327#issuecomment-221303630 Replaces #2327...

I noticed that some acceptance tests fail if I resize the browser window.