Tobias Bengfort

Results 148 comments of Tobias Bengfort

I understand the idea, but I am not yet convinced that the benefits outweigh the issues of this. Some issues are: - It would be hard to make this feature...

The trouble here is that it is not at all clear which of the HTML-AAM and accname specs takes precedence. See also https://github.com/w3c/accname/issues/8. At least that is the last info...

I believe it would be sufficient to have a model.py with the following content: ```python from django.db import models import auto_prefetch models.ForeignKey.forward_related_accessor_class = auto_prefetch.ForwardManyToOneDescriptor models.OneToOneField.forward_related_accessor_class = auto_prefetch.ForwardOneToOneDescriptor models.OneToOneField.related_accessor_class = auto_prefetch.ReverseOneToOneDescriptor...

I had a quick look at the code. Here are some thoughts: - Looks good in general - I like that it is self contained, even though I would not...

Hi, thanks for the quick response. I was thinking about the tests: For some reasons they are hanging on my laptop. I think this could be because using a `deepEqual`...

Another thing I am thinking about: Some of these tags describe functions. I think it would be very useful to consumers of this library to not just parse the raw...

I read up on ICC and the different versions (the version I implemented is ICC2 which is still in wide use, but it is from 2001 and two newer versions...

My project went another way and I don''t really need this feature anymore, so I won't have time to complete this. Feel free to close the PR or fill the...

> I have one :thinking: — should the extra filtering for `HTTP_COOKIE` and `settings.SESSION_COOKIE_NAME` live in the specific methods, `get_safe_request_meta()` and `get_safe_cookies()` respectively, rather than being added to the `cleanse_setting()`...

I am having trouble with the test case. I was trying to add a new migration that fails for some reason and then verify that this migration is not executed...