Fuqiao Xue

Results 351 comments of Fuqiao Xue

Merging per https://www.w3.org/2024/05/08-clreq-minutes.html#t03

@eternalharvest See discussions in https://github.com/w3c/contact-picker/issues/69 I agree that adding family names and given names is helpful to people in some regions, but I hope our design does not cause too...

_The first comment in this issue contains text that will automatically appear in one or more gap-analysis documents as a subsection with the same title as this issue. Any edits...

* Chromium Issue: https://bugs.chromium.org/p/chromium/issues/detail?id=409155 * WebKit Bug: https://bugs.webkit.org/show_bug.cgi?id=65917

_The first comment in this issue contains text that will automatically appear in one or more gap-analysis documents as a subsection with the same title as this issue. Any edits...

Thanks for your PR, @kirklin! Unfortunately, simply adding `darkMode: true` is not enough. We need to customize the colors in CSS with `@media (prefers-color-scheme: dark) {...}` and CSS custom properties,...

We also need to make dark mode versions for at least some of the images in the document.

Thanks for updating the PR! I made some comments. IMHO we can consider using CSS custom properties (like https://github.com/w3c/bp-i18n-specdev/pull/130/files ), so that when updating the colour, it is easier to...

And we also need to update https://github.com/w3c/clreq/blob/7d515699e5d805ddf7183173ab910a1d294ddf65/local.css#L327

Per https://github.com/w3c/respec/pull/4700 , please remove `darkMode: true` and use: ```html ```