Results 20 comments of Manuel Dipolt

> I have done a quick initial review. > > Please fix the requested changes thx, committed all requested changes, please double check if they are ok

> Drafting it as not all requested changes were implemented or commented. Please mark the PR only as ready to review when all requested changes are addressed. sorry for that,...

> A PR in draft is considered still in progress and not ready for another review. Therefore, it will not get (any) attention from the reviewers. Please mark it as...

> We require 100% test coverage for the config flow added missing testcase, now its 100%

> Something is clearing the review comments when changes are pushed so maybe avoid that if possible whats gets exactly cleared? how should i avoid push of changes or how...

> > > Something is clearing the review comments when changes are pushed so maybe avoid that if possible > > > > > > whats gets exactly cleared? how...

> I think this is ready for merge if the updating of host based on zeroconf discovery is fixed. Please note that will require a config entry update listener which...

@edenhaus https://github.com/home-assistant/core/pull/93750#discussion_r1464939398 what do you like as flow title exactly? currently: ![image](https://github.com/home-assistant/core/assets/2132412/a7b377a1-f6da-4779-bef4-ef79222b427f) without flow_title set in strings.json: ![image](https://github.com/home-assistant/core/assets/2132412/6e401ee5-7ed7-443f-9e08-f3e445926cfa)

hi, looks like fport is not defined, so support is not compiled create pull request to create also all targets with fport support: https://github.com/joelucid/betaflight/pull/10 to build it yourself, run following...

cause branch is too old and not in sync i will close it (will create new on the current master)