Xavier del Castillo comments

Results 5 comments of


                                            Xavier del Castillo

Support for filtering jobs

Note, the intent of this feature request is to only provide basic filtering capabilities when looking at a queue in a particular state, although it would be nice to think...

@BeforeInsert not firing on getRepository(<entity>).save()

Looks like a limitation on the `EventListenerMetadata` class when checking if the object is eligible to have callbacks applied to it: https://github.com/typeorm/typeorm/blob/1197f881382d5d7a1f604ab53ae34e9461bf1ffe/src/metadata/EntityListenerMetadata.ts#L61 Plain objects will not pass the validation with...

[PROPOSAL] Chained jobs

Nice proposal! It would also be useful to register children jobs depending on the state of the parent job, for example, if the job succeeded, then I want `jobB` and...

leftJoinAndMapOne and innerJoinAndMapOne now map correctly with query builder

This patch is wrong. The last argument `mapAsEntity` will cause this line to evaluate to some `EntityMetadata` and enter the `if` block: https://github.com/typeorm/typeorm/blob/46249303be03adea74266837b8e6eb49227f476e/src/query-builder/SelectQueryBuilder.ts#L2038-L2039 That `if` block will ignore the `subQuery`...

leftJoinAndMapOne does not add target property to entity

Fixed on: https://github.com/typeorm/typeorm/pull/10769