Nikita Balabaev

Results 34 comments of Nikita Balabaev

> @joperezr can advise about that. I have no idea why the analyzer get injected twice in the WPF scenario (if I am understanding the issue correctly). Correct, the issue...

@dotnet/dotnet-wpf folks, can you please suggest a good way of disabling an analyzer/source-generator (or confirm that the approach in this PR is acceptable) for WPF apps?

@RussKie, thanks! I applied your change, please review

Hello @NatMarchand, thank you for reaching out. I agree that some tags share same names in HttpClient and HTTP logging components, but you can easily distinguish them using: - log...

@NatMarchand, I see where the confusion is coming from. If log data you shared came from `HttpClientLogger` - that means that it contains data about an outgoing call only. In...

Okay, that happens because you added `RequestHeadersLogEnricher` - and it will augment all your logs emitted within the processing time of an incoming request, not only HTTP- or HttpClient-specific ones....

Alternatively, you can use `AddHttpLoggingRedaction()` instead of `AddRequestHeadersLogEnricher()` - that way you'll get one nice log record per each incoming HTTP request without any ambiguity.

I would encourage you to rely on `TraceId` to correlate logs for a particular request. Regardless, @lmolkova are there any plans in terms of adding HTTP-specific tags in SemConv for...

Not sure who will pick this up TBH. We're tracking all these telemetry issues anyway, so this one won't be missed.

@hanabi1224 if this approach looks good, then I can update other usages - https://github.com/search?q=repo%3Ahanabi1224%2FProgramming-Language-Benchmarks+ToHexString+language%3AC%23&type=code&l=C%23