xXxEMBERGHOSTSQUADDIExXx

Results 8 comments of xXxEMBERGHOSTSQUADDIExXx

i like there being a new gas but maybe this would be better as water vapor as its something more physically grokable and consistent with it making ice and wet...

another thing with making this H2O is that you could produce it and split it back and forth between H2 and O2 and turning into ice below 0C and liquid...

hows the performance on the gas reaction checking?

i recommend porting the essence of the reagent reaction code in https://github.com/vgstation-coders/vgstation13/blob/893c7b4867e1e86c07b9873bc15591367d0418c1/code/modules/reagents/Chemistry-Holder.dm#L402 and https://github.com/vgstation-coders/vgstation13/blob/893c7b4867e1e86c07b9873bc15591367d0418c1/code/modules/reagents/Chemistry-Holder.dm#L433 and https://github.com/vgstation-coders/vgstation13/blob/893c7b4867e1e86c07b9873bc15591367d0418c1/code/modules/reagents/Chemistry-Recipes.dm#L5 to try to make it easier to work with and possibly more efficient

i still dont like how it generates ice from dry air but the gas reaction system is cool and i like all the gas generalizations

maybe go through the cases mentioned in #20082 and see if it can be closed

nice, please add Closes #20082 to the pr body in that case

not sure but maybe that spawn() was in there to prevent infinite loops of signals triggering each other on the same tick or something... could be good to check