Pavel Djundik
Pavel Djundik
```js new URI("https://🤦♂️.xpaw.me").normalize().hostname() > "xn--1ug66vku9rd58h.xpaw.me" ``` Unicode inspector: https://apps.timwhitlock.info/unicode/inspect?s=%F0%9F%A4%A6%E2%80%8D%E2%99%82%EF%B8%8F However Chrome and https://www.punycoder.com/ encode it as `https://xn--g5hz781o.xpaw.me/` What's happening here?
Basically this function is not safe enough to be called on user input as it may crash with "URI malformed" which is thrown by nodejs' implementation of `decodeURIComponent` ``` /usr/local/lib/node_modules/thelounge/node_modules/urijs/src/URI.js:595...
https://github.com/nodemailer/smtp-server/blob/93e42a1b2aeab94cd4cd9db87eb874b4f807385c/lib/smtp-server.js#L198-L201 This causes a crash here: ``` TypeError: Cannot read property 'user' of undefined at node_modules/smtp-server/lib/sasl.js:461:31 at SMTPServer.onAuth (node_modules/smtp-server/lib/smtp-server.js:199:20) at SMTPConnection.SASL_XCLIENT (node_modules/smtp-server/lib/sasl.js:436:22) at checkLogin (node_modules/smtp-server/lib/smtp-connection.js:931:26) at SMTPConnection.handler_XCLIENT (node_modules/smtp-server/lib/smtp-connection.js:950:9) at SMTPConnection._onCommand...
This has happened twice in our project now, greenkeeper makes a branch which has corrupted data for whatever reason, and then the whole git repository becomes unusable until the branch...
It would be great if items the wiki is referencing would be clickable to actually lead to the entry explaining that. Alternatively, a search box could be useful for this...
 In resources, it says I have 18K oil, and construction says it also requires 18K, but it's red and the button is greyed out.
```php $queries = [ 'SELECT 1' ]; foreach( $queries as $test ) { $test = $pdo->prepare( $test ); // reusing variable $test->execute(); } ``` However this doesn't crash: ```php $test...
For content scripts, it should only be a matter of adding the urls in manifest. However, would need to detect which domain to use when loading owned games for steamdb.