Pavel Djundik

Results 332 comments of Pavel Djundik

I have a fix here: #191, unsure if there are other broken cases however.

@espy This has happened once before, and it completely borked the repository (unable to clone or push) until the relevant branch was deleted. But it's good to hear that the...

I deleted the branch via github UI, and that fixed it.

Here's the first branch that got corrupted, interestingly it's also eslint. https://github.com/thelounge/lounge/pull/1489

A simpler example: ```php $q = 'SELECT 1 FROM table WHERE'; if( true ) { $q .= ' 1=1'; } $pdo->query( $q ); ``` > Query error: SQLSTATE[42000]: Syntax error...

There are also `bindColumn` and `bindParam`.

I tried looking at this, but I can't really wrap my head around php-parser's AST. It seems that it would be pretty similar to `findQueryStringExpression`, where it finds the parent...

While there's basic support for this now, there's still things to do. In particular with bind calls being inside of `if` statements. As well as bind calls should be an...

Hmm, I briefly couldn't reproduce it either while I was shuffling versions, but after clearing cache it seems to reproduce again. Not sure why it doesn't reproduce in test suite...

> does your real world example really contains a array of literal strings above the loop? I did have an array of queries to run, yeah.