Alexander comments

Results 51 comments of


                                            Alexander

refactor(loop) separate client and loop

Wow, that's huge work, thanks for your efforts! And it looks like there's huge review work ahead :)

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

Please write in English in this repo

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

What connector are you using? Without it, the blocking luasocket functions will be used

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

Actually, if you're using a default connector, this is expected behavior to block the whole OS thread on recv() calls. This means no other code (C or Lua) will run...

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

Yes, the `luasocket.receive()` call blocks the OS thread. > sorry, I didn't get the format right I mean please enclose your code samples into `-char repeated 3 times to make...

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

1. Try to uncomment print() debug code in luasocket.send() and luasocket.receive() functions to track MQTT traffic, maybe you can find a difference for the two devices 2. Try to set...

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

I mean ``` local mq_loop = ioloop.create { timeout = 0.1, ... } ```

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

> Sorry, accidentally hit Closed ioloop itself is non-blocking，but now it is blocking，I want to know where to check timeout(default 0.005) and take effect, do you know where ？ Sorry,...

when called mqtt.ioloop is stuck，finally trace at sync_recv_func(...) stucked in function client_mt:_apply_network_timeout()

Timeout is applied to the luasocket's socket at https://github.com/xHasKx/luamqtt/blob/master/mqtt/luasocket.lua#L46 Can you please describe in more detail, what do you mean by "but I have two devices, same code, one communicating...

generic topic validation and parsing

> not sure where this should go, it's now in `init.lua`. Should it go into `client.lua` maybe? init.lua is ok as you've added a whole-module functions. > > possibly every...