moodle-logstore_xapi

moodle-logstore_xapi copied to clipboard

Two code review comments on a merged PR that it would be good to address at some point (not urgent). https://github.com/xAPI-vle/moodle-logstore_xapi/pull/367/files/08e72bdecc52fe26a4208e08a8dc82d169f8b80b#r245915624 https://github.com/xAPI-vle/moodle-logstore_xapi/pull/367/files/08e72bdecc52fe26a4208e08a8dc82d169f8b80b#r245914290

garemoko

Add facility to end emit task in the event of 404, 503 or 504 errors.

2

404, 503 and 504 errors indicate a network connectivity or LRS load issue (or the endpoint is just wrong). In these cases, it may be desirable to have the emit...

garemoko

Test data represents numbers as numbers but Moodle DB returns them as strings

2

See https://github.com/xAPI-vle/moodle-logstore_xapi/pull/388 for an example. All of our test data has numbers in the json as numbers, however when pulling the data from the Moodle database the numbers come in...

garemoko

Errors found in cron log

9

**Description** - Errors observed in the cron log when the task runs: ``` Dec 5 12:29:38 hostname sitename: Execute scheduled task: Emit records to LRS Dec 5 12:29:38 hostname sitename:...

peterspicer-catalyst

Add test coverage for when config options are enabled

4

Currently no tests exist for custom options that add/change data in statements. Currently the following need tests: - send_mbox - send_response_choices - send_short_course_id - send_course_and_module_idnumber - send_username

BrendanHalley

Include cmi.interactions_x data as extension in scorm completion

2

I'm not sure if this is a global thing, but in an Articulate SL course, the answers to assessment questions are included as cmi.interactions data. It'd be nice to capture...

davidpesce

$event->id does not exist in multiple places.

5

**Description** When going through a quiz, with the logstore app set to real time transmission to the LRS. I get the following in several places. ```` Notice: Undefined property: stdClass::$id...

caperneoignis

unable to log "delete" events

9

**Description** - when acting on deleted events (eg. course_category_deleted) the read_store_record() function does not return a record from the store and therefore does not populate and ata into the $model....

burkeallen

Welcome to [Renovate](https://redirect.github.com/renovatebot/renovate)! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin. 🚦 To activate Renovate, merge this Pull Request. To disable...

renovate[bot]

Since Moodle 4.2 the core supports xAPI states and H5P module (mod_h5p) saves the content state using xAPI states: https://tracker.moodle.org/browse/MDL-67789 Would it be possible to add those events to this...

izendegi