moodle-logstore_xapi icon indicating copy to clipboard operation
moodle-logstore_xapi copied to clipboard

Add test coverage for when config options are enabled

Open BrendanHalley opened this issue 7 years ago • 4 comments

Currently no tests exist for custom options that add/change data in statements.

Currently the following need tests:

  • send_mbox
  • send_response_choices
  • send_short_course_id
  • send_course_and_module_idnumber
  • send_username

BrendanHalley avatar Sep 26 '18 13:09 BrendanHalley

@ryansmith94 can you please assign this to me.

BrendanHalley avatar Sep 26 '18 13:09 BrendanHalley

Hey @trewq, thanks for this, just assigned you. We do have a couple of tests for send_response_choices (linked below). Those tests may serve as a useful example for the others.

  • https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/tests/mod_quiz/attempt_submitted/multichoice_withchoices/test.php#L33
  • https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/tests/mod_quiz/attempt_submitted/multichoiceset_withchoices/test.php#L33

ryasmi avatar Sep 26 '18 14:09 ryasmi

I'll be updating due to an issue I just listed where HTML formatting of the questions and response choices are being included in the string. So may update test to include this, in one or two of the response questions to ensure it is being properly handled.

caperneoignis avatar Nov 02 '18 15:11 caperneoignis

Sounds good thanks @caperneoignis 👍

ryasmi avatar Nov 03 '18 07:11 ryasmi