Robin Gareus

This is why I flagged this up for discussion, before merging the change. I suspected that they may break existing MSVC builds, but was not sure about it. You suggested...

I'd assume the better solution would be `if (spp < 1) { spp = 1; }` Then again ideally that case should not happen in the first place, and we...

I intentionally did not add a patch-change selector to the MIDI keyboard. Ardour has dedicated bank/patch selector, which not only lists the program by name, but also include bank select....

> I'm using the virtual keyboard to test Ardour's handling of program change messages coming in from a controller. I see, and yes, short of an actual keyboard that is...

> So, this plugin isn't ready to be committed yet, but I'd like to hear any discussion about it in its present form. Perhaps mark it as "Draft" then until...

> Any suggestions for how to defer processing off the DSP thread? What you really want to do is not possible with a Lua script and requires C++ code. As...

For the case at hand, I'd probably use [Mixer Scenes](https://manual.ardour.org/mixing/mixer-scenes/). and then recall a given scene using custom [MIDI bindings](https://manual.ardour.org/using-control-surfaces/midi-binding-maps/) for (Preferences > Control Surfaces) ***Generic MIDI*** surface. e.g. `~/.config/ardour8/midi_maps/pgm_scene.map`...

> but there's no way to pass in the program number or CC value Correct. Those are **_Actions_** which operate on the selection, and hence cannot take any arguments.

Given that we expect a few more release candidates anyway, I think we can make an exception here.