Ardour
MCP - Always show gain on VCAs and FBs rather than Pan
Since there is no PAN for VCA, always show gain value and if _meter then update meter based on gain value. Always show gain on Foldback Bus as well, but keeps metering working as it did previously,
@quiknick Hey, thanks for that. We are in feature freeze, so this will probably have to wait till v9.0 is out.
@prokoudine That's too bad. I have 2 more pull requests I wanted to get in before release but totally understand. Thanks!
Given that we expect a few more release candidates anyway, I think we can make an exception here.
Given that we expect a few more release candidates anyway, I think we can make an exception here.
That is excellent news as the next few are big enhancements for mackie.
@x42 @prokoudine This PR is ready to merge. I was stating I had two more separate pull requests which I plan to finish this week.
@quiknick I just tested this out on an iCON V1-M, and everything seems to work fine. Not sure how I feel about the VCA meter idea though (25193422). My first thought is meters should be used for metering, and just because VCAs don't have metering doesn't necessarily mean we need to put some other value there.
I had mixed feelings about the other two commits at first but I feel like it makes more sense now though. If you move a fader, the gain value will display on the screen. Since there's no panning for VCAs and foldbacks, we can just keep the gain value there all the time. My only apprehension is if I see "Pan" on all other displays, it might make me think that any value being shown on the same line of another display at idle is also a pan value.
Makes me think twice about just having "Pan" display for all other track types when idle in the first place. Why not just show the gain there? We can still show pan value numbers when adjusting pan, but MCU devices already have pan value indicators anyways.
I agree. I rather have the value rather than "Pan" all the time Just show Pan initially when changing to that mode. Regarding VCA metering, if you don't like my approach to it moving based on gain value of VCA then it needs to be hard set to -inf and not show a value because right now if you bank over the meter will stay on what the previous meter value was there. I still think my approach to it reflecting gain is the best approach.
This is what clears the previous value when banking so you don't have the residual on a VCA meter
/* VCA meter reset: VCAs have no peak_meter() → meters stick to previous bank.
Force zero on assignment (bank switch/session load). */
if (r && r->presentation_info().flags() & ARDOUR::PresentationInfo::VCA && _meter) {
_meter->send_update(*_surface, 0.0f);
}