Results 9 comments of x2c3z4

``` virtio_stor_hw_helper.c 568: virtio_get_config(&adaptExt->vdev, FIELD_OFFSET(blk_config, seg_max), 570: adaptExt->info.seg_max = v; 571: RhelDbgPrint(TRACE_LEVEL_INFORMATION, " VIRTIO_BLK_F_SEG_MAX = %d\n", adaptExt->info.seg_max); ``` From the code, it looks very well. I don't know why the...

The vhost-user-backend is based on spdk/dpdk. This is the qemu commands: ``` /usr/libexec/qemu-kvm -S -no-user-config -nodefaults -no-shutdown -name guest=19995ad1-d773-45da-a202-ea5d635f8cfe,debug-threads=on -uuid 41d4223f-7b0b-4c37-8a3f-c8b7342d30fe -machine pc-i440fx-rhel7.6.0,accel=kvm,usb=off,dump-guest-core=off -realtime mlock=off -rtc base=utc -rtc driftfix=slew,clock=rt -boot...

The `max_tx_length` should get from INQUIRY `block limits`(0xb0) page code. Is this the issue here? ```viostor/virtio_stor.c 487 ConfigInfo->MaximumTransferLength = ConfigInfo->NumberOfPhysicalBreaks * PAGE_SIZE; 488 ConfigInfo->NumberOfPhysicalBreaks++; 489 adaptExt->max_tx_length = ConfigInfo->MaximumTransferLength; ``` I...

Here is device: ``` -device vhost-user-scsi-pci,chardev=my-vhost-scsi-1,id=my-vhost-scsi-1,bus=pci.1,addr=0x2,bootindex=2,num_queues=2 ``` @vrozenfe max_sectors default is 0xFFFF here.

Set max_sectors to 64 works well. @vrozenfe ``` -device vhost-user-scsi-pci,chardev=my-vhost-scsi-0,id=my-vhost-scsi-0,bus=pci.1,addr=0x1,bootindex=1,num_queues=2,max_sectors=64 ```

@vrozenfe > Then keep it as 64. Your physical backend has 126 segments limit. SPDK vhost-user-scsi/blk backend set the 126 limit. Don't you think this is a bug? I think...

@vrozenfe I don't think so. Why not keep it consistent with the linux kernel driver and comply with the SCSI protocol? Let' check the [spec]( http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-2610006) ``` 5.6.4 Device configuration...