Wojciech Zięba

Results 49 comments of Wojciech Zięba

Also the first expand has strange animation (like height is way overestimated). Maybe we could resolve this in the same ticket? https://user-images.githubusercontent.com/5845095/139472388-a9f3490d-a2ae-4a2b-a4bf-60008892d2f5.mov

hi @kidinov 👋 . This looks like solid work but I won't be able to review this PR soon - I've learned about baseline profiles, this sounds really interesting but...

hi @thehenrybyrd ! I think it's expected on Android, it follows Material Design guidelines: https://material.io/components/tabs#usage - please see `Scrollable tabs` fragment.

> And it seems Google doesn't follow these guidelines 😄 You're right. I don't know which approach will be the best, the smaller offset should also work. I think we...

Thanks! I'm not sure when I'll have time to do this. If someone wants to take it - PRs are welcomed.

Nice idea, thanks! I'm adding this to the backlog but if anyone is willing to work on that, please feel free to provide a PR.

@0nko just a heads up that I merged #2286 today so it'll for sure will be conflicting with this PR when merging to trunk.

`data class` is not possible in this case as WellSql generates `WCOrderModelMapper#convert` method which requires mutable fields of the entity: ![image](https://user-images.githubusercontent.com/5845095/137712034-9a2e55a3-db7c-4f4e-82ae-94e8eed55589.png)

Thanks, @0nko - do you have any information about affected Woo releases?