Wenqi Li
Wenqi Li
the previous change of this was because of efficiency https://github.com/Project-MONAI/MONAI/pull/486, is this PR verified for the same?
I think it's in this PR only, and I couldn't find out the reason...most likely from the unit tests?
/black > @wyli Any idea why I'm seeing [this](https://github.com/Project-MONAI/MONAI/runs/7694587970?check_suite_focus=true#step:8:12033)? The import is nested in an `optional_import`. I see, that's an issue from type annotations and you've addressed that.
/build Hi @Nic-Ma, I can make the minor doc updates in https://github.com/Project-MONAI/MONAI/pull/4838
/build
/build
error from the tests, I suspect the docker image lacks FFmpeg which is under GPL licence @rijobro @binliunls any idea? ``` [2022-08-08T13:17:56.960Z] ====================================================================== [2022-08-08T13:17:56.960Z] ERROR: test_dataset (tests.test_video_datasets.TestVideoFileDataset) [2022-08-08T13:17:56.960Z] ---------------------------------------------------------------------- [2022-08-08T13:17:56.960Z]...
> ok, the VideoDataset module is generic and doesn't strictly require ffmpeg, the test cases need it. do you have simpler test cases?
there is a version of opencv in our docker image release, it's probably from the base image and compiled without ffmpeg. In order to use the video dataset, what would...
I think you can locally revert to an earlier state with `git reflog` good luck...