Wenqi Li

Results 315 comments of Wenqi Li

> Perform the transform reordering as described above This reordering is already ambiguous for cache Vs non-cache use cases, it'll be 'breaking the pipeline' by your definition. But I don't...

> It isn't ambiguous for cache vs non-cache. There are clear rules. Agreed, that's what we have on the Dev branch, that's what we have for lazy resampling on the...

> there are plenty of users who won't be using the caching / persistent mechanisms I don't think that's a valid/good assumption for monai now and future

ok, in the interests of time for releasing v1.2, just to reiterate my understanding: 1. to me the changes that you propose are not fundamentally different from the current dev...

Sure, that's good. Implementation-wise, do you plan to include all the code changes in PR #6257 and what's the timeline? If needed I can help run some benchmarks and integration...

Theres work in progress https://github.com/Project-MONAI/MONAI/pull/1793 for that, but need a major rework to use the latest API

Hi @atbenmurray please discuss with the core dev team before self-assigning feature request.

> In the process of addressing this in PR #7140 it's unclear to me why a single PR is used to address multiple, separate significant bugs (https://github.com/Project-MONAI/MONAI/issues/7130 https://github.com/Project-MONAI/MONAI/issues/7139 https://github.com/Project-MONAI/MONAI/issues/7146). it...

sure, that's great @nhhung1810, please see: - how to prepare a pull request https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md - would be great to revise the related docstring with a bit more details, following this...