Weibing Wang

Results 115 comments of Weibing Wang

> > 用gflag如果有多个server的情况不能区分各自server的指标,个人觉得这类server spefic的属性放server option更合理一些。 LGTM

可能是你机器上有多个protobuf版本,头文件引用的是一个版本,链接时用的是另一个版本

Thanks for reporting the issue and submitting this PR! I think it's better to add some comments to explain the code, or add some test cases, to prevent future modification...

Maybe we can add a notice at the beginning of the document, stating that this document is automatically translated?

The master branch has fix CI problem, please rebase.

The master branch has fix CI problem, please rebase.

和master近期合入的PR产生了冲突,需要解决一下

看起来是mold的行为和其它ld不兼容,参考:https://github.com/rui314/mold/issues/524 有一个解决方案是gcc编译源码时加上-fno-gnu-unique选项

Fixed by https://github.com/apache/incubator-brpc/pull/1936