Wim Van Deun

Results 11 comments of Wim Van Deun

Good point. Not sure if we can rely on the fact that `r.json()` will always succeed. AFAIK it will raise an exception if the response body is not valid JSON,...

What is the use-case you would want to tackle with these groups? I'm not in favor of adding these attributes as groups. For Region and Site Group, implementing these would...

Can you elaborate a bit more on your use case? If you apply a different role and/or platform to your VirtualMachines compared to your devices, then you should be able...

I still seem to have issues when I ssh to another host from within vterm. Haven't debugged or looked into it to much yet...

Are you still planning on merging this PR or is there something missing that we can help with?

This is some poc code for multicontext support. It is roughly implemented like this: When open() is called, we perform a check to see if the device is in multicontext...

Hi @dbarrosop I think we want some feedback/review from you here. We are looking to implement multicontext support. I'm assuming you are familiar with the context concept, if not I...

That's why we were involving you, we don't want anything to break. I do like a combination of both alternatives that you bring up. Optionally accept a context argument when...

I've removed the optional parameter from the methods. Added a context property + safeguard Context property needs to be set to execute subsequent methods on that specific context. https://github.com/enzzzy/napalm-asa/commit/86ecaf9bb48f3c53093f29c3a283e3a5ef4516fa

can you have a look here https://github.com/enzzzy/napalm-asa/commit/4e31c228a940e1b81251a240ca73913812d42558 ? I've implemented multi context support for all getters as discussed above. I've added a file _MC_INCOMPATIBLE_ENDPOINTS.py that holds all the endpoints that...