Jacob Scott

Results 26 comments of Jacob Scott

@krlmlr is the view then that this isn’t going to be supported, so the errors should just be more informative?

Is this possibly a good place to also look at #4116? It seems like the `blob` type can't be written from R, so possibly should be included among the types...

> Thanks. Could you avoid using the Windows line ending? If you are using RStudio, you can set it here (you might also need to review your Git settings as...

> Thanks, looks almost good. Random comments: > * I think we should add at least one example to show how just works briefly. > * When used with some...

> It is not too difficult to just build this on top of `element_text()` if you want. > > ```r > library(ggplot2) > library(stringr) > > element_text_transform elem elem$transform class(elem)...

Apologies, my initial example was a bit rushed and possibly didn't show my issue clearly enough. Perhaps this edit will help clarify. Here, columns would indicate monthly totals of `value`,...

I think it's very close. Correct me if I'm wrong, but I think that usually the width of the columns would be `0.9 * 29`, not `0.9 * 30`. I...

Would you be happy to review a PR if I submitted one? To be honest I think it'd be quite simple to implement.

Great, I'll get working on something. Good point about the interface. I think, for the sake of consistency, you're right that `hjust` is better, not least because `vjust` would also...

A bit of extra feedback. Currently abbreviated columns are listed in the same paragraph as omitted column names - I think an extra linebreak here would improve readability. They also...