Valentin Wüstholz

Results 42 comments of Valentin Wüstholz

@cd1m0 Maybe we should use a different operator (e.g., `encodingEq(a, b)`) instead of `==` to avoid confusion. What do you think? In general, it seems like this can become very...

I'm not quite sure I fully understand the question. The case where the external input is provided by a contract is the only case we care about here. If users...

I would say requirement violations are always "wrong". However, it's more challenging to determine who is to blame (see the two cases in the description about how to fix them)....

Yes, using `require` statements is perfectly fine to filter invalid inputs. Essentially, by adding them, the programmer implicitly introduces assertions that external contracts or users should adhere to. I can...

I also like option 3. About contract invariants: I think it's worth thinking carefully about where the checks should happen. In the literature on class/object invariants there are many different...

@aryx Thanks! I think this is a separate issue. I used Docker and the develop-branch to verify that this is still happening after the fix in https://github.com/returntocorp/semgrep/pull/6040.

@ggrieco-tob Thanks a lot for the quick reply! Just to clarify: with `stopOnFail: true` Echidna will stop **the entire campaign** as soon as it finds any violation. In contrast, with...

@ggrieco-tob I just tried the process I described above, but it doesn't report additional violations. These are the steps I followed: ``` $ mkdir current-corpus $ printf 'testLimit: 1000000000\ntimeout: 120\ncoverage:...

@ggrieco-tob Thanks a lot for the clarification! I'll try to use the `covered.txt` file in that case. I have posted a summary of this discussion here: https://github.com/crytic/echidna/pull/674#issuecomment-888098672.