Martin Kirilov
Martin Kirilov
Is anyone supporting this?
Definitely. The same applies to the cursor pagination. I'll look into it this or the following week, as I'd need to understand how tests are setup in the project, I...
@soyuka What's the difference between `src/Core/GraphQl/Type/TypeBuilder.php` and `src/GraphQL/Type/TypeBuilder.php`? To my understanding, according to the imports, the former is going away in favor of the latter?
`TypeBuilderTest::testPageBasedGetResourcePaginatedCollectionType` passes, but requires more assertions added as it does not assert what the collection consists of, only its presence. Edit: Done
@soyuka Please review. Furthermore, I am completely clueless as to what the semantic pull request wants from me, so please advise on title.
``` And the JSON node "data.type2.fields" should contain: """ { "name":"edges", "type":{ "name":null, "kind":"LIST", "ofType":{ "name":"DummyAggregateOfferEdge", "kind":"OBJECT" } } } """ ``` must become ``` And the JSON node "data.type2.fields"...
Anyone? Do we lose some of the strictness of these behat tests since the type is now wrapped in a notNull, or how else should we proceed, can we somehow...
Please review. Also added two more cases to test the `$resourceType instanceof NullableType` if-statements, in case type hints are added to `Type::nonNull` Not sure where to place the `DummyNotImplementingNullableInterfaceType` class
I guess noone cares, if anyone cba, feel free to fork
Happens when we have '$$$' as a value of an object property When we changed that to \`$$$\`, it reformatted it as `$