William Moses
William Moses
With readonly/readnone/writeonly being no longer permissible as llvm fn args in later LLVM's a nice way to query for this would be helpful
It makes use of a loop pass like JuliaLICMPass more difficult
https://github.com/Argonne-National-Laboratory/Checkpointing.jl/blob/5cacc30d614963def9c78f1d152f6caaff576fc9/src/Rules/EnzymeRules.jl#L15 @michel2323 this line seems to have a correctness issue. It's not necessarily the cause of a different issue @swilliamson7 and I were debugging, but seems sufficiently bad that it...
https://github.com/TuringLang/NormalizingFlows.jl/blob/58d3e57e66872274a1b6f46ffe68fc54da642d90/ext/NormalizingFlowsEnzymeExt.jl#L21 This line can be weakened from ReverseWithPrimal to just Reverse, since you don't use the result. Moreover the issue referenced in the comments above have been closed/resolved
https://godbolt.org/z/1cKv1e5cc
x/ref https://github.com/JuliaMath/QuadGK.jl/pull/110
see https://github.com/EnzymeAD/Enzyme.jl/issues/1693#issuecomment-2289210905 cc @swilliamson7