William Moses

Results 889 comments of William Moses

Looks like a CMake issue on windows. I don't have a windows machine to reproduce/debug, but I don't see any blockers besides someone finding a machine to test and fix...

The problem is specifically the Microsoft c++ compiler iirc, it should be successful with say clang or cygwin on windows On Sun, May 19, 2024 at 8:41 PM Owen Troke-Billard...

@avik-pal the `fast_activation!!` issue is closed, let me know if anything else is blocking there.

Oh I think you just got unlucky. That was fixed almost immediately after in Enzyme On Fri, Jul 12, 2024 at 8:33 AM Tim Besard ***@***.***> wrote: > @wsmoses Can...

Just wanted to express support for this here as it also helps with adding plugins for AD

Make sure to add both Enzyme forward and reverse modes!

I might not go quite that low level to save yourself some common LLVM setup, but probably using the thunk level (https://github.com/wsmoses/Enzyme.jl/blob/2ce81ffa8f56c5bf44a4d85234c2110fa9d6eb0a/src/compiler.jl#L2700) which has options for "combined" augmented forward pass+gradient,...

@mohamed82008 mind addressing the above comments and getting this merged?

Did you apply the changes I suggested above in code review?

@mohamed82008 @devmotion the failures look to me as all issues from tuples in the AD interface, not anything which fails to be differentiated by Enzyme. If those can get fixed,...