Wilfredo Sánchez Vega

Results 96 comments of Wilfredo Sánchez Vega

@hawkowl Does the release of `16.12` mean we did this?

Currently erroring out in Mypy: ```console mypy run-test: commands[0] | mypy --cache-dir=/Users/wsanchez/Dropbox/Developer/Twisted/klein/.tox/mypy_cache --pretty release.py setup.py src src/klein/test/test_app.py:529:10: error: Argument 1 has incompatible type "Callable[[Any, str], Union[Union[str, bytes, Any, Any], Awaitable[Union[str,...

OK I think I'm remembering that the problem here isn't that we are defining a function with variable arguments, but that we want to define a type that fit for...

I might be wishing for https://github.com/python/mypy/issues/5876

Still a draft… not sure what the best fix for the Mypy error is.

[PEP 0612](https://www.python.org/dev/peps/pep-0612/) may be what we need to proceed here, and is in Python 3.10.

My suggestion would be: ``` class MyApplication(object): router = Klein() ``` That is: we should refer to a `Klein` instance as a "router", and to classes that contain a router...

Waiting to work on this after #308 #311 and #301 merge.

I made a 1.0.0 milestone and am moving this to that milestone.

I feel like your use case needs a little more use-y-ness…