Wilfredo Sánchez Vega

Results 96 comments of Wilfredo Sánchez Vega

Changing `cmp=False` to `eq=False` gives me a more glorious error: ```console src/ims/application/_main.py:74:2: error: No overload variant of "attrs" matches argument types "bool", "bool", "bool", "bool" [call-overload] @attrs(frozen=True, auto_attribs=True, kw_only=True, eq=False)...

@euresti For #2, should it be enough to simply install `attrs`? In Tox, I turned off `skip_install` so that dependencies are installed: ```console wsanchez$ ./.tox/mypy/bin/pip freeze | grep '^attrs' attrs==19.1.0...

It seems like overloading `attr.ib`, versus adding a new `attr.ib_class` may become increasingly problematic. It's already clear here that there are different behaviors in play here, so a lot of...

OK, y'all in deeper in the black magic that I've normally gone, so my assumptions are off. Uh… thanks for doing that do I don't have to. :-)

There's a bit you left out in the code you say this is equivalent to, which is what happens when you say: ```python >>> c = C() >>> c.x =...

Oh, I guess for more complete completeness: ```python C.x = "another value" ``` Which I assume is out of the `attrs` problem scope…?

YYMV, but I think it's a bad pattern to tightly couple the names of symbols in a class def to your serialization format. This probably won't be the only time...

You could also make moo a property… Unless you are using `frozen=True` on the class, that arguably makes a bit more sense; it seems weird to not allow setting a...

This may be something to think about in the context of the `__setattr__` conversation; presumably this validation should happen any time `x` or `y` are assigned to. In which case,...

@shashankchaudhry Sorry I should have included a pointer. See #645. Since we are considering validation when attributes are assigned to, then even a validator not specific to a given attribute...