tinyosc icon indicating copy to clipboard operation
tinyosc copied to clipboard

pattern matching via regex

Open artfwo opened this issue 8 years ago • 3 comments

basic pattern matching. this implementation translates osc address patterns to regular expressions and provides a method for matching messages against the latter.

artfwo avatar Oct 15 '17 01:10 artfwo

Hey, thanks for taking the initiative on this! I have a few things I'd like to see addressed before merging, if they're not too much trouble. First, I'd prefer that the regex dependency is pinned at least to "0.2" to avoid potential breakage in the future. And second, would you mind adding additional tests for the other special OSC pattern characters?

wrl avatar Oct 15 '17 22:10 wrl

@wrl, on it :)

artfwo avatar Oct 16 '17 03:10 artfwo

@wrl ok, added a few tests and some additional checks in the translator, looks good?

artfwo avatar Nov 15 '17 08:11 artfwo