Bill Avery

Results 23 comments of Bill Avery

Sorry for the delay, I've been very busy over the last month. Maybe you've already come up with a solution, but the approach I'd try would be to create a...

Interesting, I never noticed the [aliasing contructor](https://en.cppreference.com/w/cpp/memory/shared_ptr/shared_ptr) on `std::shared_ptr` before.๐Ÿ‘๐Ÿผ Perhaps because of that, I would always be inclined to make the member a `std::shared_ptr` as well. I worry that...

> > I think it would also need to be possible to return a type-erased object wrapper by value then, and that version of the wrapper object would need to...

The reason I favored r-value references is that we have another static analyzer rule internally which warns against passing values larger than `4 * (sizeof(void*))`. The explanation is that this...

I think the threshold for that rule's trigger (`4 * sizeof(void*)`) is probably a heuristic. I've also heard a rule of thumb that you should pass by reference for anything...

It's derived from the filename, which comes from the `--prefix` argument to `clientgen`. Since they're all the same, I'm assuming you are generating them in different directories. Rather than naming...

Yes, you do also need to disambiguate the namespace.

BTW, here's what I built with it: [cppgraphqlgen](https://github.com/Microsoft/cppgraphqlgen). ๐Ÿ˜

That's pretty much what I would have suggested, but I didn't have a pre-compiled copy of the sample, so this is much better. ๐Ÿ‘๐Ÿผ The touch input APIs in Windows...

If I'm reading that right, the Linux version could be fixed here with `https://localhost`: https://github.com/tauri-apps/wry/blob/3a6eefae66c41da0f09293911675cb3c094e58b5/src/webview/webkitgtk/mod.rs#L212 And the macOS version would be here: https://github.com/tauri-apps/wry/blob/3a6eefae66c41da0f09293911675cb3c094e58b5/src/webview/wkwebview/mod.rs#L404