William Parr

Results 13 comments of William Parr

Beyond using a UUID etc. for tracking a sync triggered by applicationset-controller - I wonder if we should store the revision of a sync when it's out of date /...

@jannfis Thanks for the feedback. I'm not sure that in either of the approaches suggested on my part ie. usage of a generated ID (the contents of this PR as...

@jannfis my assumption was along the lines of what you replied here: ``` You will get the target revisions as long as the application has synced at least once, otherwise,...

Following up on this @jannfis, any chance a maintainer could have a look over this.

Following up here @crenshaw-dev, did you get a chance to run locally? Any concerns? Thanks

Ran against linters now @nickfloyd! Thanks :)

@kfcampbell Sure no problem! Sorry if I wasn't clear. Current implementation of this resource is utilising the [GitHub Contents API](https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28). We get some verified signature support using this like auto...

Hey @kfcampbell @nickfloyd thanks for getting around to looking at these 👀 Let me quickly fix the conflicts

Plus one on the above @crenshaw-dev. It would be great to get this merged off, as we would like to be able to use the feature 🙏 Anything I can...