Edwin Takahashi

Results 19 comments of Edwin Takahashi

> I wouldn't do this: many autofixes are known to be buggy (I personally had issues with the jsdoc rules) or approximate. They require manual inspection before committing. Unlike Prettier...

@john-legg I've assigned you this review. If you aren't sure, feel free to reach out to me or hop on a quick call for me to explain the changes.

The failure in Gutenberg simple E2E tests edge (mobile) is due to the build being manually added then cancelled by me. It was an accidental build trigger.

> Sorry for the delay, @worldomonation. The changes make sense to me! I'll go ahead and approve it. > > **question (non-blocking):** Do you mind showing me the sites you...

Ran every unique-ish build configuration and everything has passed so far.

> this is ultimately pushed to production servers > ... > t does start from the base image in most cases here Hmm, that's a good catch - I hadn't...

> When I manually trigger the e2e tests again, it doesn't utilize the Docker image build I manually triggered as well -- instead, it resolves the Docker image used in...

On 09/22 I rebased this on then-latest `trunk`, triggered a docker base image build with the custom tag `bullseye-slim` (previously unused tag), then triggered multiple E2E and other supporting tasks...

> Cool! In practice, how would this get used? This would be used to experiment with pushing test results data from TeamCity to an external data store (eg. Grafana/ElasticSearch or...

I had a look over the proposed changes and while I have quite a few questions, I'll start with the one that would affect the course of future action the...