Tan Jun Rong
Tan Jun Rong
## Overview Currently, the `parseAndSendLintResult` task does too many things. 1. It takes in `lint-results.xml` produced `./gradlew lint`. 2. It then parses it. 3. Then it renders the result into...
Currently the `lint-results.xml` for testing only has **warnings**. Try it with errors
Moshi addresses many shortcomings of gson, so it's worth to change it: https://www.reddit.com/r/androiddev/comments/684flw/why_use_moshi_over_gson/
Network call error in rx chain in `CommentViewModel.kt` is not handled. It should be handled by showing a simple text message at the very least.
In `CommentViewModel.kt`, the following html color cannot be changed based on dark/day theme. It should be extracted into own resources file. ```kotlin "${commentData.author}" ```
After having comments and login, there will be data consistency issue. For example, upvoting in Comment View doesn't update the view in Home Feed View. By introducing Room, and by...
subreddit list is getting too long, it's hard to choose from other than using the random button categorized them into a nested list