Łukasz Kużyński comments

Results 12 comments of


                                            Łukasz Kużyński

Adding className to the <i> element

AFAIR this should work. ```js ``` Since "otherProps" are forwarded to target element https://github.com/sairion/svg-inline-react/blob/master/lib/index.js#L94

Migrating TypeScript?

I can create Declaration file (index.d.ts) for this module but I don't believe everyone will remember to update it. Would you mind if I rewrite the module in Typescript?

Webpack Bundling

I'm sorry. @TaichiHo Why do you need webpack in order to deploy it on AWS Lambda?

Create index.d.ts

@jonschlinkert Looks ok. We can merge it please :)

Returning empty object where it should not

I believe we should not use `is-extendable` library in order to check whether a value is an object as it's simply confusing and not valid. `is-extendable` checks whether object is...

Rename Number.toPosInteger to Number.toNatural

What about creating an alias instead?

Rename Number.toPosInteger to Number.toNatural

Maybe it's time for version 1.0 :)?

Rename all valid(ate)-* modules into ensure-*

Most of the functions "is_" and "validate_" that I know return boolean and never throw an exception. Functions "assert*" throw an exception when a check fails. Your "valid*" functions throw...

Fixed types of Either.fromTry

@JSMonk I've updated readme within that PR. Did I miss some part of documentation?

Fixed types of Either.fromTry

I can. What's the benefit of it though?